-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Switch to /usr/bin/time
for measuring time + memory in physmon
#3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 3005785physmon summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
=======================================
Coverage 48.68% 48.68%
=======================================
Files 493 493
Lines 29052 29052
Branches 13850 13850
=======================================
Hits 14143 14143
Misses 4965 4965
Partials 9944 9944 ☔ View full report in Codecov by Sentry. |
AJPfleger
reviewed
Mar 5, 2024
This reverts commit 0d6b87a.
andiwand
previously approved these changes
Mar 5, 2024
andiwand
approved these changes
Mar 5, 2024
🔴 Athena integration test results [d455e02]🔴 Some tests have failed!Please investigate the pipeline! |
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Mar 7, 2024
…cts-project#3007) I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
andiwand
added a commit
to andiwand/acts
that referenced
this pull request
Mar 8, 2024
…physmon (acts-project#3007)" This reverts commit d455e02.
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Mar 11, 2024
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
acts-project#3017) Reverting acts-project#3007 as it seems to break the physmon exit code propagation
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…cts-project#3007) I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
acts-project#3017) Reverting acts-project#3007 as it seems to break the physmon exit code propagation
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…cts-project#3007) I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
acts-project#3017) Reverting acts-project#3007 as it seems to break the physmon exit code propagation
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fails Athena tests
This PR causes a failure in the Athena tests
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.